Skip to content

fix property value leak in DefaultParser.handleProperties - #441

Open
rootvector2 wants to merge 1 commit into
apache:masterfrom
rootvector2:default-parser-property-leak
Open

rootvector2 wants to merge 1 commit into
apache:masterfrom
rootvector2:default-parser-property-leak

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

handleProperties calls processValue on the Option registered in Options instead of on the copy that handleOption clones into the CommandLine, so a default applied in one parse() stays on the shared Options and every later parse() on it returns that stale value while an explicit -a two on the command line is pushed into the args list; found while checking why DefaultParser never clears option values the way the legacy Parser does for CLI-71.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code helped write the fix, the test, and this description.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

handleProperties applied the Properties value to the Option registered in Options instead of the copy that handleOption adds to the CommandLine, so the value survived the parse() call and every later parse() on the same Options reused it, even when the option was given on the command line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant