fix infinite loop in TextHelpAppendable.makeColumnQueue at width 1 - #442
Open
rootvector2 wants to merge 1 commit into
Open
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
indexOfWrap chops a line without whitespace at limit - 1, which is startPos when the width is 1, so makeColumnQueue re-reads the same position and grows its queue until the heap is exhausted. appendList hits this with default settings for an 8 character entry containing a line break because it sizes the wrap width from the entry length, and throws for shorter entries. Always consume at least one character in indexOfWrap and wrap list entries at the configured width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeColumnQueuenever terminates when the usable width is 1 becauseindexOfWrapchops a line without whitespace atlimit - 1, which isstartPos, andappendListreaches that width (or 0, which throws) for any entry with a line break of at most 8 characters since it sizes the wrap width from the entry rather than the page, soindexOfWrapnow always consumes one character and list entries wrap at the configured width; found while reviewing thehelpwrapping after #437.mvn; that'smvnon the command line by itself.