Repository navigation
Strengthen OSGi factory tests - #118
Merged
garydgregory merged 1 commit intoNov 8, 2026
Merged
Conversation
Verify that all six secure default factory entry points select their expected JDK implementations when the thread context class loader is the library's OSGi bundle loader. Set each factory's provider property to a nonexistent provider during its check so an accidental fallback to ordinary provider discovery cannot silently pass. Restore each property afterward. Add isolated class-loading tests for FallbackIgnoreLSResourceResolver so its static initializer executes independently for each scenario. Verify that: - A failed lookup through the context class loader succeeds on retry through the system class loader. - A failed retry retains the original lookup exception as suppressed. - Both successful and failed retries restore the caller's context class loader. Skip these initialization tests in native images and on Android, where their class-loading assumptions do not apply. Clarify the OSGi test Javadoc: only the initial default-factory checks use the bundle loader as the thread context class loader. The reused unit tests retain the launcher's context loader because XSLTC-generated translets require visibility of JDK internals. Document the suite's explicit class, method, and tag exclusions. Assisted-By: OpenAI Codex
garydgregory
force-pushed
the
strengthen-osgi-factory-tests
branch
from
November 8, 2026 12:36
3045697 to
dc860f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strengthen OSGi factory tests.