ci: sweep TPC-H/TPC-DS verification over partition counts and empty tables - #2201
Draft
andygrove wants to merge 7 commits into
Draft
ci: sweep TPC-H/TPC-DS verification over partition counts and empty tables#2201andygrove wants to merge 7 commits into
andygrove wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — test-infrastructure follow-up to the correctness bugs fixed in #2185, #2186, #2188, and #2194.
Rationale for this change
The recent correctness bugs shared a pattern: a distributed plan rewrite that was structurally plausible but semantically wrong, triggered by runtime conditions our CI never produces. The
--verifyoracle (cluster result vs single-process DataFusion) runs only at--partitions 16on full TPC-H SF10 / TPC-DS SF1 data, which never yields an empty intermediate stage and never exercises low partition counts.This PR makes CI exercise exactly those conditions.
What changes are included in this PR?
--empty-tables <t1,t2,...>flag on both benchmark drivers. It registers the named tables as zero-row Parquet mirrors (schema inferred from the real data) in both the Ballista session and the--verifyoracle, so verification remains a valid comparison while every query touching an emptied table produces empty intermediate stages through the distributed planner. On the TPC-H driver it requires--format parquetand is incompatible with--expected.lineitem/orders/supplier,nation). Job/step timeouts added so a hang fails fast, and cluster logs now upload on timeout as well as failure.target_partitions=1andtarget_partitions=2legs alongside the existing 16-partition task-packing legs.benchmarks/README.mddocumentation for the new flag.Notes for maintainers:
--skipthe affected query with an issue link rather than reverting the leg.Empty tables for this run: ...— reproduce locally with that printed set via--empty-tables.Are there any user-facing changes?
No. The new CLI flag is on the benchmark binaries only; no library or cluster behavior changes.