refactor: centralize data type support predicates#5025
Open
peterxcli wants to merge 3 commits into
Open
Conversation
peterxcli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5021.
Depends on #4976.
Rationale for this change
Data-type support checks are duplicated across sinks, local scans, and shuffle paths, making new type support error-prone.
What changes are included in this PR?
Centralize recursive capability checks in
QueryPlanSerde.supportedDataTypeand reuse them across existing call sites while preserving their boundary-specific behavior.How are these changes tested?
Added recursive capability coverage and ran focused Spark 4.1 and Spark 3.5 tests, interval SQL tests, Spotless, and Scalastyle.