Conversation
github-actions
Bot
added
build
dev/ci/check-suites.py only checked one direction: every suite in the source tree must appear in a workflow. It never checked the reverse, so six suite names that no longer exist stayed in the linux-test and macOS matrices. ParquetReadV2Suite was removed in apache#3671, and none of the six has a class, trait or object declaration in any sourceset. CI stays green only because the suites are passed as -DwildcardSuites, which silently ignores unmatched names; an explicit -Dsuites list fails with ClassNotFoundException. Add the forward check and remove the six dead lines. ParquetReadV1Suite and CometStringDecodeSuite are kept: the former is declared in ParquetReadSuite.scala and the latter in the spark-3.x sourceset used by the 3.4/3.5 profiles.
ErikBPF
force-pushed
the
ci/drop-nonexistent-suites
branch
from
September 22, 2026 01:16
c120e89 to
f4810f0
Compare
ErikBPF
marked this pull request as ready for review
September 22, 2026 01:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None. Small CI-hygiene follow-up; no tracking issue.
Rationale for this change
dev/ci/check-suites.pyonly verified that every suite in the source tree islisted in a workflow. It never verified the reverse, so six suite names that no
longer exist remained in the
linux-testand macOS matrices:org.apache.comet.CometExpressionCoverageSuiteorg.apache.comet.exec.CometAsyncShuffleSuiteorg.apache.comet.exec.DisableAQECometAsyncShuffleSuiteorg.apache.comet.parquet.ParquetReadV2Suite(removed in chore: Remove deprecated SCAN_NATIVE_COMET constant and related test code #3671)org.apache.spark.sql.comet.ParquetDatetimeRebaseV1Suiteorg.apache.spark.sql.comet.ParquetDatetimeRebaseV2SuiteCI is green only because the suites are passed via
-DwildcardSuites, whichignores unmatched names; an explicit
-Dsuiteslist fails withClassNotFoundException. The matrices therefore claim coverage that does notrun, and nothing prevented a stale name from being re-added.
What changes are included in this PR?
dev/ci/check-suites.py: a suite listed ina workflow must be declared as a
class/trait/objectin some sourceset..github/workflows/pr_build_linux.ymland
.github/workflows/pr_build_macos.yml.ParquetReadV1SuiteandCometStringDecodeSuitestay listed: the former isdeclared in
ParquetReadSuite.scala, the latter in thespark-3.xsourcesetused by the 3.4/3.5 profiles.
How are these changes tested?
python3 dev/ci/check-suites.pyreports the six undeclared names (RED) beforethe removal, then prints
All workflow-listed suites are declaredand exits 0after it.