Skip to content

perf: cache Iceberg FileIO per executor instead of building one per task #6106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mixermt wants to merge 3 commits into
base: main
Choose a base branch
from
+295 −29
Open

perf: cache Iceberg FileIO per executor instead of building one per task #6106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d1f6ed
perf: cache Iceberg FileIO per executor instead of building one per task
mixermt Sep 22, 2026
841cbb0
perf: evict FileIO cache entries one at a time and test the hit path
mixermt Sep 22, 2026
36ffdc1
perf: do not cache a FileIO whose S3 access provider failed to initia…
mixermt Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions native/core/src/cloud/s3/credential_bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ use std::time::Duration;
/// executor from holding a stale credential for the entire job lifetime.
const DEFAULT_EXPIRY_WHEN_UNKNOWN: Duration = Duration::from_secs(300);

/// Once-per-process latch for the "missing expiry" warning. Bridges are per-scan, so a per-bridge
/// latch would re-log on every scan.
/// Once-per-process latch for the "missing expiry" warning. Bridges live as long as their entry in
/// the executor's FileIO cache, so a per-bridge latch would re-log for every new configuration.
static WARNED_MISSING_EXPIRY: OnceCell<()> = OnceCell::new();

/// Access intent forwarded to the Java SPI. Ordinal must match the JVM `CometS3AccessMode` enum.
Expand Down
1 change: 1 addition & 0 deletions native/core/src/execution/jni_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,7 @@ pub fn get_runtime() -> Handle {
/// Must not be called from within the runtime's own worker threads, otherwise the shutdown
/// would deadlock/panic.
pub fn release_runtime() {
crate::execution::operators::clear_file_io_cache();
let runtime = TOKIO_RUNTIME.lock().take();
if let Some(runtime) = runtime {
runtime.shutdown_timeout(Duration::from_secs(3));
Expand Down
Loading