Conversation
iceberg-spark-extensions ran unsharded and was the longest job in a queue run (55m24s). Shard it exactly like the core iceberg-spark task: the shared shard matrix, --init-script, -PcometShardTask for its own task, and per-shard inventory uploads verified by a new iceberg-spark-extensions-shard-coverage job. dev/ci/check-ci-config.py gains check_iceberg_extensions_shards() so the job cannot silently lose its shard wiring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6103.
Rationale
The
iceberg-spark-extensionsjob ran unsharded and was the longest job in theIceberg workflow — 55m24s in a recent merge-queue run, against four shards for the
core
iceberg-sparktask. It now uses the same shard machinery as the core task.What changes
iceberg-spark-extensionstakes the shared shard matrix(
fromJSON(needs.build-native.outputs.shard-matrix),fail-fast: false), gainsthe
/shard-${{ matrix.shard }}name suffix, and passes the same Gradle wiring asthe core task:
--init-script ../dev/ci/iceberg-test-shards.gradle,-PcometShardTask=:iceberg-spark:iceberg-spark-extensions-...:test,-PcometShardIndex/-PcometShardCount.iceberg-spark-extensions-shard-coveragejob verifies the extensionstask's inventories (
check-iceberg-shards.py --manifests ... --task ...extensions...:test),mirroring the core coverage job.
dev/ci/check-ci-config.pygainscheck_iceberg_extensions_shards()so the jobcannot silently lose its shard wiring.
Expected effect
~55m24s → projected ~15-20 min for the extensions job, roughly 35 queue-minutes
per run. This is the largest single saving identified in the CI review.
How it was tested
python3 dev/ci/check-ci-config.py→CI config checks passed.python3 dev/ci/test-iceberg-shards.py→ 15 tests OK.unshardedCandidatesinventory need one label run to confirm. The new coveragejob fails if the union of shard candidates is not exactly the unsharded
inventory, so a bad split cannot merge silently.
Constraint
SHARD_COUNT = 4indev/ci/check-iceberg-shards.pyis global; the extensionstask reuses the same count.