Repository navigation
Conversation
When behavior varies between Spark versions, resolve the version in Scala and pass native code a parameter that describes the behavior. Add the guidance to the contributor guide and the expression skills.
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. Follows the review discussion on #6740.
Rationale for this change
In #6740 the question came up of why the new protobuf flag is named
wrap_second_millisecond_overflowrather thanspark_420_plus. The reasoning is worth writing down so contributors and reviewers apply it consistently:What changes are included in this PR?
adding_a_new_expression.md: new "Name the behavior, not the Spark version" subsection under "API Differences Between Spark Versions", including guidance to write comments as "Spark 4.2 and later" when later releases inherit the behavior.review-comet-prandreview-comet-expression-prskills: reviewers flag parameters, proto fields, and comments named for a Spark version instead of the behavior.implement-comet-expressionandwire-datafusion-functionskills: point authors to the new guide section.How are these changes tested?
Documentation only. Checked with prettier.