Repository navigation
Conversation
…ferences, add 1.3.0 upgrade note
Delete spark/src/main/spark-3.4 and spark/src/test/spark-3.4, which no profile builds since the spark-3.4 profile was removed, and update the CI path filters and docs that referenced them.
andygrove
marked this pull request as ready for review
November 9, 2026 12:55
manuzhang
approved these changes
Nov 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4329.
Rationale for this change
#7521 removes the
spark-3.4Maven profile and stops running Spark 3.4 in CI, but leaves the Spark 3.4 shim source sets behind. Nothing builds them now, so they are dead code that has to be kept in step with the other shims. This is the follow-up that deletes them.What changes are included in this PR?
spark/src/main/spark-3.4/andspark/src/test/spark-3.4/. Every file in them has a counterpart inspark-3.5/or is a 3.5-only addition there, so thespark-3.5,spark-3.xandspark-4.xsource sets are unchanged.spark-3.4path entries fromdev/ci/compute-changes.py. They only excluded edits to the deleted directory from triggering other jobs.ShimCometMapInBatch,GenerateDocs).spark-3.4as a shim directory, and redrawshim_pattern.svgwith the 3.5 and 4.x editions.Deliberately not touched:
get_json_object_spark34function. The Spark 3.4 shim was its only caller, but it is a named behavior flag that Rename Cast.is_spark4_plus and get_json_object_spark34 to describe the behavior they select #6891 already tracks renaming, so it is better handled there.dev/diffs/3.4.3.diffanddev/diffs/iceberg/1.8.1.diff, as in chore: remove Spark 3.4 Maven profiles and stop running Spark 3.4 CI #7521."3.4.3"cases in the version-parsing unit tests and thebit_count_types.sqlinterpreted-mode workaround. They are harmless and can go in a later cleanup.How are these changes tested?
python3 dev/ci/check-ci-config.py,check-versioned-source-parity.pyandcheck-suites.pypass.prettier --checkpasses on the changed Markdown, andshim_pattern.svgparses as XML.