Repository navigation
Conversation
4 of 40 tasks
gabotechs
reviewed
Oct 19, 2026
terbed
force-pushed
the
feat/page-index-pruning
branch
from
October 20, 2026 20:58
d89efcb to
f95e1a6
Compare
Author
|
Thanks @gabotechs for taking the time to review and comment on this PR.
This approach significantly simplified the pr, the main complexity is proving page index pruning's effect. That could be a separate focused PR if such test would be important/necessary. Would you recommend further changes? Or could this PR in this form be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62
Forward
datafusion.execution.parquet.enable_page_indexto Iceberg'sscan builder. Iceberg scans now follow the session setting, including
DataFusion's enabled default.
Add regression coverage for reduced Parquet reads with identical query
results, explicit disabling, files without page indexes, and nullable
decimal columns with projection. Tests cover both static and
catalog-backed table providers.
Update the Iceberg dependency to include apache/iceberg-rust#3314, which prevents incorrect row elimination for decimal predicates when page-index pruning is enabled. Adjust existing tests for the updated dependency’s API changes.