Conversation
PostgreSQL allows an explicit trailing '*' after a table name in FROM to indicate that descendant tables should be included, e.g. SELECT * FROM tbl_name*. This was previously only supported for TRUNCATE and LOCK TABLE targets, not for FROM items. Also renamed the existing has_asterisk fields on TruncateTableTarget and LockTableTarget to has_trailing_asterisk for consistency and clarity. https://www.postgresql.org/docs/current/sql-select.html#SQL-FROM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, PostgreSQL's
FROM tbl_name*syntax (asterisk explicitly indicating that descendant tables should be included) failed to parse:This was already supported for
TRUNCATE TABLE name*andLOCK TABLE name*, but not for regularFROMitems.Docs: https://www.postgresql.org/docs/current/sql-select.html#SQL-FROM
Fix
has_trailing_asteriskfield toTableFactor::Table, parsed the same way as the existing asterisk handling inTRUNCATE/LOCK TABLE.has_asteriskfields onTruncateTableTargetandLockTableTargettohas_trailing_asteriskfor naming consistency.This PR was created with AI assistance.