Skip to content

feat: extend interval analysis support for temporal types#21520

Merged
berkaysynnada merged 6 commits intoapache:mainfrom
buraksenn:extend-interval-analysis-temporal
Apr 17, 2026
Merged

feat: extend interval analysis support for temporal types#21520
berkaysynnada merged 6 commits intoapache:mainfrom
buraksenn:extend-interval-analysis-temporal

Conversation

@buraksenn
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

related with #21109 and its PR #21473

Rationale for this change

Temporal types can actually support internal arithmetics and with this change internal arithmetics can now narrow down column boundaries and selectivity instead of falling back to default selectivity of 1.0

What changes are included in this PR?

Extend internal_arithmetic types with date and duration types

Are these changes tested?

Yes adjusted tests

Are there any user-facing changes?

no

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates common Related to common crate physical-plan Changes to the physical-plan crate labels Apr 9, 2026
@github-actions github-actions bot added the core Core DataFusion crate label Apr 9, 2026
Comment thread datafusion/expr-common/src/interval_arithmetic.rs
Comment thread datafusion/common/src/scalar/mod.rs
Copy link
Copy Markdown
Contributor

@berkaysynnada berkaysynnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor issues

@berkaysynnada berkaysynnada added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 17, 2026
@berkaysynnada berkaysynnada added this pull request to the merge queue Apr 17, 2026
Merged via the queue into apache:main with commit 6cd7e83 Apr 17, 2026
35 checks passed
@berkaysynnada berkaysynnada deleted the extend-interval-analysis-temporal branch April 17, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Extend single-value NDV optimization to timestamp and interval types

2 participants