Skip to content

Make TopKDynamicFilters public - #25429

Draft
masonh22 wants to merge 1 commit into
apache:mainfrom
masonh22:pub-topk-dyn-filters
Draft

masonh22 wants to merge 1 commit into
apache:mainfrom
masonh22:pub-topk-dyn-filters

Conversation

@masonh22

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

TopKDynamicFilters is needed as an argument to TopK::try_new(), so without it it's impossible to construct a TopK.

What changes are included in this PR?

What is the testing strategy for this PR?

Are there any user-facing changes?

This is needed as an argument to `TopK::try_new()`, so without it it's
impossible to construct a `TopK`.
@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Sep 17, 2026
masonh22 added a commit to coralogix/arrow-datafusion that referenced this pull request Sep 17, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.33%. Comparing base (3ab72e6) to head (a265ecd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25429      +/-   ##
==========================================
- Coverage   82.34%   82.33%   -0.01%     
==========================================
  Files        1137     1137              
  Lines      432364   432364              
  Branches   432364   432364              
==========================================
- Hits       356020   356002      -18     
- Misses      54830    54847      +17     
- Partials    21514    21515       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants