fix: Reject negative RANGE window frame offsets - #25816
Open
goutamadwant wants to merge 1 commit into
Open
goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25816 +/- ##
==========================================
+ Coverage 82.50% 82.51% +0.01%
==========================================
Files 1141 1141
Lines 438825 439887 +1062
Branches 438825 439887 +1062
==========================================
+ Hits 362050 362989 +939
- Misses 54892 54947 +55
- Partials 21883 21951 +68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
INTERVALoffsets in RANGE window frames are accepted and panic at execution #24902.Rationale for this change
Negative RANGE frame offsets can pass planning and cause an execution panic or incorrect window results. ROWS and GROUPS offsets are already rejected during planning.
What changes are included in this PR?
What is the testing strategy for this PR?
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningsAre there any user-facing changes?
Negative RANGE offsets now produce a planning error instead of reaching execution. There is no public API change.