Repository navigation
Conversation
…ay be stale Readers of the updatable structure use N. The structure is Java-only. Also fixes the bullet's n > 1, since an empty updatable image exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Javadoc only, in
KllPreambleUtil's description of theUPDATABLEstructure.The empty and single-item flags are set when an updatable image is written, but a sketch updated in place never changes them. On a direct sketch, the empty flag stays set after an update to n = 1, and the single-item bit stays clear. Nothing depends on them:
KllMemorySegmentValidatechecks the flags only for the compact structures, andisEmpty()uses N. The comment now says so, and that this structure is Java-only.Also in the same bullet: the structure is used for any n, including an empty sketch (the old text said n > 1), and a doubled period is fixed.
No code change.
javac -Xlint:all -Xdoclint:all,-missingreports nothing for the file.🤖 Generated with Claude Code