branch-4.1: [fix](workload group) Drain adaptive flush callbacks before pool teardown #68264 - #68326
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…down (#68264) ### What problem does this PR solve? Adaptive flush callbacks can outlive the ThreadPool objects they borrow. Workload group ID changes make teardown cancel a different registration name, and timer cancellation can miss a rearmed timer or free its state before an already-started callback acquires its mutex. These races can crash the backend during workload group changes or shutdown. - Save a stable, per-pool registration key and cancel it even when adaptive adjustment has subsequently been disabled. - Read the final timer ID under the callback mutex, then wait for brpc to finish any running callback before releasing its state. - Serialize registration, cancellation and stop; drain duplicate registrations and reject registration after stop. - Stop adaptive callbacks before backend pool teardown, and cancel registrations on direct WG scheduler destruction. ### Release note Fix backend crashes caused by adaptive flush callbacks accessing released thread pools during workload group changes or backend shutdown.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #68264