Skip to content

[fix](function) Reject overflowing IPv6 uint128 strings - #68334

Open
Mryange wants to merge 1 commit into
apache:masterfrom
Mryange:fix-ipv6-uint128-overflow
Open

Mryange wants to merge 1 commit into
apache:masterfrom
Mryange:fix-ipv6-uint128-overflow

Conversation

@Mryange

@Mryange Mryange commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Problem Summary: ipv6_from_uint128_string_or_null accepted empty strings and decimal values larger than uint128, causing digit-by-digit parsing to wrap around and produce an incorrect IPv6 value. Root cause: the parser performed unchecked multiplication and addition. This change rejects empty input and checks the value before each decimal accumulation so invalid input is converted to NULL by the existing nullable function path.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Issue Number: N/A

Problem Summary: IPv6 decimal strings beyond the uint128 range previously wrapped during digit-by-digit parsing, and empty strings were accepted as zero. Add explicit empty-input and overflow checks so invalid values are rejected and the nullable function can return NULL.

### Release note

None

### Check List (For Author)

- Test: Focused BE ASAN unit test FunctionIpTest.IPv6FromUInt128StringRejectsEmptyAndOverflow

- Behavior changed: Yes (invalid empty and out-of-range values are rejected)

- Does this need documentation: No
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange

Mryange commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants