branch-4.1: [fix](be) Preserve tablet ID in synchronous file cache writes #68310 - #68347
Merged
Merged
Conversation
The synchronous CachedRemoteFileReader path constructed CacheContext without copying the reader tablet ID. Cache misses were downloaded correctly, but newly created FileBlock and persisted block metadata used the no-tablet sentinel 0. Runtime per-tablet cache inspection and TTL registration therefore could not associate those new blocks with their Doris tablet. This change propagates the Doris tablet ID into the synchronous cache context. External readers are normalized to the existing no-tablet sentinel 0 for both synchronous and asynchronous writes, and TTL registration defensively accepts only positive tablet IDs. ### Release note Fix synchronous file cache blocks to retain their Doris tablet ID while preserving no-tablet metadata for external readers.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
1 similar comment
Contributor
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Sep 23, 2026
Contributor
Author
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #68310