Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
Prepared with Codex and approved for submission by @ecoyoung.
What does this PR do?
Parse
YYYY-Wwwas Monday of the ISO week at local midnight, matching existing date inputs without a timezone.Fixed issues
Closes #21578.
Details
Before: What was the problem?
Values such as
2026-W04produce invalid dates on a time axis.After: How does it behave after the fixing?
2026-W04resolves to January 19, 2026. Cross-year weeks are supported; invalid week numbers, including week 53 in a 52-week year, are rejected. This adds no dependency and does not add week-day/time parsing or week-label formatting.Document Info
English and Chinese docs are in apache/echarts-doc#535 (draft pending the release target).
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
198 unit tests pass, including parsing and dataZoom coverage. The affected suites also pass in New York and Berlin timezones. Typecheck, lint, and header checks pass.
Merging options
Other information
The new parsing tests fail before this change.