FINERACT-2684: Add "App is ready" message to log - #6387
Open
adamsaghy wants to merge 1 commit into
Open
Conversation
adamsaghy
force-pushed
the
FINERACT-2684/app-is-running-message
branch
from
September 7, 2026 13:18
7aae2cc to
cc1fe78
Compare
TianHengZhuang
left a comment
TianHengZhuang
left a comment
Contributor
There was a problem hiding this comment.
Excellent approach using @EventListener for Spring lifecycle events!
- Separation of concerns: A dedicated
FineractApplicationLifecycleLoggercomponent is clean — no coupling to the main application class. volatilecontext field: Good thread-safety practice sinceApplicationReadyEventandContextClosedEventmay fire on different threads.- Test coverage: The two test cases cover HTTPS+context-path and IPv6+root context. Consider adding a third test for plain HTTP (no SSL) with default port for completeness.
- README note: The
BUILD CANCELLEDGradle message explanation is valuable for new developers.
Solid implementation. ✅
TianHengZhuang
approved these changes
Sep 8, 2026
TianHengZhuang
left a comment
TianHengZhuang
left a comment
Contributor
There was a problem hiding this comment.
LGTM — well-structured Spring lifecycle observer pattern, minimal and focused. The tests provide good confidence. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add "App is ready" and "App is shutting down" (not these words) message for better clarity over the lifecycle of the running Fineract instance