Skip to content

FINERACT-2639: Enforce office hierarchy checks for account transfers - #6420

Open
elnafateh wants to merge 1 commit into
apache:developfrom
elnafateh:FINERACT-2639/enforce-office-hierarchy-access-checks
Open

FINERACT-2639: Enforce office hierarchy checks for account transfers#6420
elnafateh wants to merge 1 commit into
apache:developfrom
elnafateh:FINERACT-2639/enforce-office-hierarchy-access-checks

Conversation

@elnafateh

Copy link
Copy Markdown
Contributor

Description

Adds centralized office-hierarchy authorization checks for account transfers across savings and loan accounts, including transfer creation, refunds, top-ups, and undo operations.
Adds unit and integration coverage for unauthorized cross-office transfers.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@elnafateh

Copy link
Copy Markdown
Contributor Author

@adamsaghy kindly review this when u get a chance

@adamsaghy

Copy link
Copy Markdown
Contributor

@adamsaghy kindly review this when u get a chance

I am traveling this week. The earliest i can review is next week. :(

@elnafateh

Copy link
Copy Markdown
Contributor Author

@adamsaghy kindly review this when u get a chance

I am traveling this week. The earliest i can review is next week. :(

Safe travels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants