[FLINK-39767][tests][JUnit5 migration] Module: flink-statebackend-forst#28261
Open
spuru9 wants to merge 4 commits into
Open
[FLINK-39767][tests][JUnit5 migration] Module: flink-statebackend-forst#28261spuru9 wants to merge 4 commits into
spuru9 wants to merge 4 commits into
Conversation
Migrate all JUnit 4 tests in flink-statebackend-forst to JUnit 5 (Jupiter): - Replace org.junit.* imports with org.junit.jupiter.api.* - @Before/@After/@BeforeClass/@afterclass -> @BeforeEach/@AfterEach/@BeforeAll/@afterall - @Rule/@ClassRule TemporaryFolder -> @tempdir + TempDirUtils helpers - @test(expected = X.class) -> assertThatThrownBy(...).isInstanceOf(X.class) - @RunWith(Parameterized.class) -> @ExtendWith(ParameterizedTestExtension.class) with Flink's @Parameters/@parameter annotations and @testtemplate - Hamcrest + org.junit.Assert.* assertions -> AssertJ (project convention) - Drop extends TestLogger and public modifiers per the migration guide
Collaborator
… tests For ForSt tests that only need one fresh temp dir per method, switch from the TempDirUtils helper + field to native JUnit 5 @tempdir parameter injection: - ForStInitITCase.testTempLibFolderDeletedOnFail(@tempdir File tempFolder) - ForStMemoryControllerUtilsTest.ensureRocksDbNativeLibraryLoaded(@tempdir Path) - ForStMultiClassLoaderTest.testTwoSeparateClassLoaders(@tempdir Path tmp) - ForStOperationsUtilsTest @BeforeAll/@test both take own @tempdir param The remaining files (ForStResourceContainerTest, ForStStateBackendConfigTest, ForStStateBackendFactoryTest, ForStIncrementalCheckpointRescalingTest) keep TempDirUtils because they create many subdirs from one parent root, which is the documented use case for the helper per the Flink JUnit 5 migration guide.
…mentalCheckpointRescalingTest The file doesn't import org.apache.flink.core.fs.Path so the FQN 'java.nio.file.Path' wasn't needed; use a normal import instead.
Contributor
Author
|
@snuyanzin Can you review this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate all JUnit 4 tests in
flink-state-backends/flink-statebackend-forstto JUnit 5 (Jupiter) as part of the ongoing migration tracked under FLINK-25325. This eliminates the last JUnit 4 imports from the ForSt module.JIRA: FLINK-39767
Brief change log
9 test files migrated:
ForStIncrementalCheckpointRescalingTest— parameterized:@RunWith(Parameterized.class)→@ExtendWith(ParameterizedTestExtension.class)with@TestTemplateForStInitITCaseForStMemoryControllerUtilsTestForStMultiClassLoaderTestForStNativeMetricOptionsTestForStOperationsUtilsTestForStResourceContainerTestForStStateBackendConfigTestForStStateBackendFactoryTestPer-file changes:
org.junit.*imports →org.junit.jupiter.api.*@Before/@After/@BeforeClass/@AfterClass→@BeforeEach/@AfterEach/@BeforeAll/@AfterAll@Rule TemporaryFolder/@ClassRule TemporaryFolder→@TempDir java.nio.file.Path+TempDirUtils.newFolder(...)/TempDirUtils.newFile(...)@Test(expected = X.class)→assertThatThrownBy(...).isInstanceOf(X.class)org.junit.Assert.*→ AssertJ (project convention)extends TestLoggerandpublicmodifiers per the Flink JUnit 5 Migration GuideNo production code is touched.
Verifying this change
This change is a test refactor and is covered by the migrated tests themselves:
Result: 976 tests run, 0 failures, 0 errors, 5 skipped. Total test count and pass/skip distribution match the pre-migration baseline.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?