[FLINK-36267][table] Fix SPLIT not preserving SMP characters when delimiter is empty#28264
Open
Au-Miner wants to merge 1 commit into
Open
[FLINK-36267][table] Fix SPLIT not preserving SMP characters when delimiter is empty#28264Au-Miner wants to merge 1 commit into
Au-Miner wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix the SQL
SPLITfunction so that, when called with an empty delimiter, it preserves Supplementary Multilingual Plane characters (e.g. emoji) as single elements instead of breaking surrogate pairs into invalid "?" placeholders.Brief change log
SplitFunction#evalto iterate by Unicode code points (codePointAt+Character.charCount) instead of by UTF-16 code units, so surrogate-pair characters are emitted as one element.Verifying this change
Added a new test case in
CollectionFunctionsITCase#splitTestCasesthat assertsSPLIT('123😊笑脸', '')returns["1", "2", "3", "😊", "笑", "脸"], covering the SMP character path across both Table API and SQL.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation