[FLINK-40117][runtime-web] Extend Vitest smoke-test coverage to more web-dashboard views#28742
Open
spuru9 wants to merge 1 commit into
Open
[FLINK-40117][runtime-web] Extend Vitest smoke-test coverage to more web-dashboard views#28742spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
Collaborator
Contributor
Author
|
@MartijnVisser Can you take a look. Have added additional tests to cover most of the component tests. |
…web-dashboard views FLINK-40035 introduced a Vitest setup with smoke tests for three views. Extend that coverage to the remaining high-traffic pages so more of the dashboard is guarded against breakage during Angular/ng-zorro upgrades. Add smoke specs for: - Job: overview, checkpoints, timeline, data skew, rescales, configuration - Task Manager: metrics, logs - Job Manager: metrics - Application (cluster) overview Each spec mocks the view's services through TestBed and asserts that the component loads its data and populates its key bindings. Chart- and graph-backed views (timeline, job overview) drive the component logic directly and stub the rendering layer, which relies on browser APIs jsdom does not implement. Also add a no-op Web Worker stub to src/test-setup.ts: @antv/g2 creates a worker at module load for its label layout, and Worker is undefined in jsdom. Generated-by: Claude Code (claude-opus-4-8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
FLINK-40035 added a Vitest test setup with smoke tests for three web-dashboard views. This PR extends that baseline coverage to the remaining high-traffic pages, so more of the dashboard is guarded against regressions during Angular / ng-zorro upgrades. Tests run in jsdom through the existing
@angular/build:unit-testbuilder, so no browser is required.Brief change log
TestBedand asserts that the component loads its data and populates its key bindings. Chart- and graph-backed views (timeline, job overview) drive the component logic directly and stub the rendering layer, which relies on browser APIs jsdom does not implementsrc/test-setup.ts:@antv/g2creates a worker at module load for its label layout, andWorkeris undefined in jsdomVerifying this change
This change adds tests and can be verified as follows:
cd flink-runtime-web/web-dashboard && npm cinpm run test:ci— 13 test files / 29 specs pass (the 10 new spec files plus the 3 from FLINK-40035)npm run lintpassesDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-opus-4-8)