[FLINK-40530][runtime-web] Isolate per-entry failures in job overview aggregation - #29062
[FLINK-40530][runtime-web] Isolate per-entry failures in job overview aggregation#29062argoyal2212 wants to merge 1 commit into
Conversation
… aggregation A single malformed archive no longer aborts the whole /jobs/overview update; it is skipped and logged, and a good overview is kept if all entries fail.
|
@zentol @gaborgsomogyi @dmvk Can I please get some help on this PR review. Thanks! |
Jackeyzhe
left a comment
There was a problem hiding this comment.
Thanks for this PR, LGTM
spuru9
left a comment
There was a problem hiding this comment.
LGTM
Optional: As this will have effect on the UI, could help with a comparison. Can skip if not easy to reproduce the instance.
@spuru9 Thanks! This is a backend-only change and no UI/frontend code is touched. The user-visible effect is on the /jobs/overview data the UI renders: today, one incompatible archive causes the entire job list to go blank but after this fix, all other jobs render correctly and only the incompatible entry is skipped. |
What is the purpose of the change
HistoryServerArchiveFetcher#updateJobOverview()aggregates every archived job's overview JSON into one combined/jobs/overviewresponse. Today a single malformed or version-incompatible archive throws during aggregation and aborts the whole update, silently returning empty/stale overview data for every job, not just the offending one. This PR adds per-entry isolation so one bad archive can no longer take down the entire job listing.Brief change log
updateJobOverview()now catches and skips a single archive's parse failure instead of letting it abort the whole aggregationVerifying this change
This change added tests and can be verified as follows:
testUpdateJobOverviewSkipsMalformedEntryInsteadOfFailingEverything, which injects one malformed per-job overview entry alongside a valid one and asserts the valid job is still listedtestUpdateJobOverviewDoesNotWipeGoodOverviewWhenAllEntriesAreMalformed, which corrupts the only entry and asserts the previously written combined overview is preserved rather than replaced with an empty oneDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI