Skip to content

[common][helm] helm support for config providers#3685

Merged
fresh-borzoni merged 3 commits into
apache:mainfrom
fresh-borzoni:config-provider-review-followups
Jul 21, 2026
Merged

[common][helm] helm support for config providers#3685
fresh-borzoni merged 3 commits into
apache:mainfrom
fresh-borzoni:config-provider-review-followups

Conversation

@fresh-borzoni

@fresh-borzoni fresh-borzoni commented Jul 17, 2026

Copy link
Copy Markdown
Member

closes #3686

On the helm side, secrets become declarative:

 secrets:
   mounts:
     - name: paimon-creds
       secretName: fluss-paimon-creds

 configurationOverrides:
   datalake.paimon.s3.secret-key: ${directory:/etc/fluss/secrets/paimon-creds:secret-key}

The chart generates the config.providers config with allowed.paths/env allowlist derived from the declared entries, so the rendered server.yaml stays a plain ConfigMap with no secret material.

Plus some follow-ups from the #3658 review threads:

  • allowed.paths canonicalization now fails closed
  • duplicate provider identifiers on the classpath fail fast
  • test + docs pinning the gated $${ escape semantics

@fresh-borzoni fresh-borzoni changed the title Config provider review followups [common][helm] helm support for config providers Jul 17, 2026
@fresh-borzoni
fresh-borzoni force-pushed the config-provider-review-followups branch 4 times, most recently from 0a20066 to 806f2f7 Compare July 17, 2026 16:21
@fresh-borzoni
fresh-borzoni force-pushed the config-provider-review-followups branch from 806f2f7 to 228def5 Compare July 17, 2026 16:23
@fresh-borzoni
fresh-borzoni force-pushed the config-provider-review-followups branch from 228def5 to d167c44 Compare July 17, 2026 16:30
@fresh-borzoni

Copy link
Copy Markdown
Member Author

@morazow @affo A bit more helm conveniences :) PTAL 🙏

@affo affo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fresh-borzoni thank you so much for this contrib!

Most of my comments are nits, the contribution looks already very good

Comment thread website/docs/install-deploy/deploying-with-helm.md
Comment thread helm/templates/_secrets.tpl Outdated
Comment thread helm/values.yaml
Comment thread helm/values.yaml
@fresh-borzoni
fresh-borzoni force-pushed the config-provider-review-followups branch from 8bc9340 to 89d7dde Compare July 20, 2026 23:56
@fresh-borzoni

Copy link
Copy Markdown
Member Author

@affo Thank you for the review, addressed, PTAL 🙏

@fresh-borzoni
fresh-borzoni requested a review from affo July 21, 2026 00:00

@affo affo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you Anton!

@fresh-borzoni
fresh-borzoni merged commit e21a035 into apache:main Jul 21, 2026
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[helm] Declarative secrets support for config provider markers

2 participants