HBASE-30136 Upgrade hbase-server to use junit5 Part15#8283
Merged
Conversation
Member
liuxiaocs7
commented
May 28, 2026
- for branch-2
- see: HBASE-30136
There was a problem hiding this comment.
Pull request overview
This PR continues the HBASE-30136 effort (branch-2, Part 15) by migrating a large set of hbase-server regionserver tests from JUnit 4 to JUnit 5. The changes modernize test annotations/assertions, replace @Category with JUnit 5 tags, and update parameterized tests to use HBase’s JUnit 5 parameterized template support.
Changes:
- Convert JUnit 4 assertions/annotations/rules (
@Test,@Before,@Rule,@Category,Assume, etc.) to JUnit 5 equivalents (@Test,@BeforeEach,@Tag,Assumptions,TestInfo, etc.). - Replace JUnit 4
TestNameusage with JUnit 5TestInfo-derived test names for table/dir naming. - Migrate JUnit 4 parameterized tests to JUnit 5 using
@HBaseParameterizedTestTemplate/@TestTemplate(and, where applicable, JUnit 5@ParameterizedClass).
Reviewed changes
Copilot reviewed 56 out of 56 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java | JUnit 5 migration: assertions, tags, and TestInfo-based naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java | JUnit 5 migration: assumptions, tags, and TestInfo-based naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFlushRegionEntry.java | JUnit 5 migration: lifecycle annotations and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFlushLifeCycleTracker.java | JUnit 5 migration: lifecycle annotations and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFailedAppendAndSync.java | JUnit 5 migration: lifecycle annotations, assertions, TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java | JUnit 5 migration: lifecycle, assertions, tags, TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionRandomKeying.java | JUnit 5 migration: lifecycle, assertions, tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionKeyRotation.java | JUnit 5 migration: lifecycle, assertions, tags, TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionDisabled.java | JUnit 5 migration: assertThrows-based exception assertions and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDirectStoreSplitsMerges.java | JUnit 5 migration: lifecycle, tags, TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDeleteMobTable.java | JUnit 5 migration: assertions, lifecycle, tags, TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java | JUnit 5 migration: assertions and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java | JUnit 5 migration plus new test-name building/sanitization helpers and refactored setup/teardown hooks. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java | JUnit 5 migration: assertions and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicyOverflow.java | JUnit 5 migration: tags/annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicyHeterogeneousStorage.java | JUnit 5 migration: tags/annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicy.java | JUnit 5 migration: tags/annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java | JUnit 5 migration: assertions, tags, lifecycle updates. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataBlockEncodingTool.java | JUnit 5 migration: @BeforeEach and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCustomCellTieredCompactionPolicy.java | JUnit 5 migration: assertions and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCustomCellDataTieringManager.java | JUnit 5 migration: assertions/tags and minor javadoc link update. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompoundBloomFilter.java | JUnit 5 migration: assertions, tags, @BeforeEach. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSplitThread.java | JUnit 5 migration: lifecycle annotations and assertDoesNotThrow. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactorMemLeak.java | JUnit 5 migration: assertions, tags, TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionWithShippingCoprocessor.java | JUnit 5 migration: tags/lifecycle and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionWithCoprocessor.java | JUnit 5 migration: tags/annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionWithByteBuff.java | JUnit 5 migration: tags/lifecycle annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java | JUnit 5 migration: tags/lifecycle and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionPolicy.java | JUnit 5 migration: lifecycle annotations and assertions. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionLifeCycleTracker.java | JUnit 5 migration: tags/lifecycle and @Disabled. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionInDeadRegionServer.java | Migrates parameterized test to @HBaseParameterizedTestTemplate + constructor injection + @TestTemplate. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionFileNotFound.java | JUnit 5 migration: tags/lifecycle; simplify compaction exception handling. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveIOException.java | JUnit 5 migration: tags/lifecycle and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveConcurrentClose.java | JUnit 5 migration: tags/lifecycle and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionAfterBulkLoad.java | Migrates to @HBaseParameterizedTestTemplate/@TestTemplate; updates temp folder usage. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java | JUnit 5 migration: assertions, tags, lifecycle, TestInfo naming, Assumptions usage. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellFlatMapMemStore.java | Migrates parameterized-class style to JUnit 5 @ParameterizedClass + @MethodSource. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingMemStore.java | Refactors to hook into new TestDefaultMemStore setup/teardown and JUnit 5 tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java | JUnit 5 migration: tags and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestClusterId.java | JUnit 5 migration: tags/lifecycle annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestClearRegionBlockCache.java | Migrates parameterized test to @HBaseParameterizedTestTemplate + constructor injection + @TestTemplate. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCleanupMetaWAL.java | JUnit 5 migration: tags/lifecycle annotations; cluster shutdown updated. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCleanupCompactedFileOnRegionClose.java | JUnit 5 migration: assertions/tags/lifecycle. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCleanupCompactedFileAfterFailover.java | JUnit 5 migration: assertions/tags/lifecycle. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCellSkipListSet.java | JUnit 5 migration: tags/lifecycle and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCellFlatSet.java | Migrates parameterized test to @HBaseParameterizedTestTemplate + @TestTemplate. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java | Migrates parameterized test to @HBaseParameterizedTestTemplate + @TestTemplate; uses TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBytesReadServerSideScanMetrics.java | JUnit 5 migration: assertions, tags, TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java | Migrates parameterized base to JUnit 5 @TempDir and Stream<Arguments> parameters provider. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java | Migrates parameterized test to @HBaseParameterizedTestTemplate + @TestTemplate; uses assertThrows. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBrokenStoreFileCleaner.java | JUnit 5 migration: tags/lifecycle annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBootstrapNodeManager.java | JUnit 5 migration: tags/lifecycle and assertion imports. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBloomFilterFaulty.java | JUnit 5 migration: tags/lifecycle and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksScanned.java | JUnit 5 migration: tags/lifecycle annotations. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java | JUnit 5 migration: tags/lifecycle and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java | JUnit 5 migration: tags/lifecycle, assertions, and TestInfo naming; javadoc link update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Same question, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.