Skip to content

HBASE-30188 Upgrade hbase-server to use junit5 Part20#8286

Open
Apache9 wants to merge 3 commits into
apache:masterfrom
Apache9:HBASE-30188
Open

HBASE-30188 Upgrade hbase-server to use junit5 Part20#8286
Apache9 wants to merge 3 commits into
apache:masterfrom
Apache9:HBASE-30188

Conversation

@Apache9
Copy link
Copy Markdown
Contributor

@Apache9 Apache9 commented May 30, 2026

No description provided.

@Apache9 Apache9 self-assigned this May 30, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the HBASE-30188 migration of hbase-server replication-related tests from JUnit 4 to JUnit 5, while splitting shared test logic into reusable base classes for endpoint and region-server kill variants.

Changes:

  • Replaces JUnit 4 lifecycle/assertion/category APIs with JUnit Jupiter APIs and @Tag.
  • Extracts replication endpoint and kill-RS test logic into shared base classes with thin concrete subclasses.
  • Updates multi-WAL and replication master tests to align with the JUnit 5 migration.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
TestReplicationSyncUpToolWithBulkLoadedData.java Migrates sync-up bulk-load test assertions/tags to JUnit 5.
TestReplicationSyncUpToolBase.java Converts setup/teardown lifecycle hooks to JUnit 5.
TestReplicationSyncUpTool.java Migrates sync-up tool tests and assertions to JUnit 5.
TestReplicationKillSlaveRSWithSeparateOldWALs.java Rewires separate-old-WAL slave kill test to new base.
TestReplicationKillSlaveRS.java Converts concrete slave kill test to JUnit 5 subclass.
TestReplicationKillMasterRSWithSeparateOldWALs.java Rewires separate-old-WAL master kill test to new base.
TestReplicationKillMasterRSCompressed.java Converts compressed master kill variant to JUnit 5 setup.
TestReplicationKillMasterRS.java Converts concrete master kill test to JUnit 5 subclass.
TestReplicationEndpoint.java Reduces endpoint test to tagged JUnit 5 subclass.
ReplicationKillSlaveRSTestBase.java Adds shared slave-RS kill test method.
ReplicationKillRSTestBase.java Renames/refactors common kill-RS logic for JUnit 5 bases.
ReplicationKillMasterRSTestBase.java Adds shared master-RS kill test method.
ReplicationEndpointTestBase.java Adds shared endpoint tests, helpers, and endpoint implementations.
multiwal/TestReplicationSyncUpToolWithMultipleWAL.java Migrates multi-WAL sync-up variant tags to JUnit 5.
multiwal/TestReplicationSyncUpToolWithMultipleAsyncWAL.java Migrates async multi-WAL sync-up variant tags to JUnit 5.
multiwal/TestReplicationKillMasterRSCompressedWithMultipleWAL.java Recreates compressed multi-WAL setup on new base.
multiwal/TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL.java Recreates compressed async multi-WAL setup on new base.
multiwal/TestReplicationEndpointWithMultipleWAL.java Rewires endpoint multi-WAL variant to new base.
multiwal/TestReplicationEndpointWithMultipleAsyncWAL.java Rewires endpoint async multi-WAL variant to new base.
master/TestReplicationLogCleaner.java Migrates log cleaner test lifecycle/assertions/tags to JUnit 5.
master/TestRecoverStandbyProcedure.java Migrates standby recovery procedure test lifecycle/assertions/tags.
master/TestLogCleanerBarrier.java Migrates log cleaner barrier test to JUnit 5.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +92 to +96
@AfterAll
public static void tearDownAfterClass() {
// check stop is called
assertTrue(ReplicationEndpointForTest.stoppedCount.get() > 0);
}
*/
package org.apache.hadoop.hbase.replication;

import static org.junit.Assert.assertNull;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants