HBASE-30188 Upgrade hbase-server to use junit5 Part20#8286
Open
Apache9 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR continues the HBASE-30188 migration of hbase-server replication-related tests from JUnit 4 to JUnit 5, while splitting shared test logic into reusable base classes for endpoint and region-server kill variants.
Changes:
- Replaces JUnit 4 lifecycle/assertion/category APIs with JUnit Jupiter APIs and
@Tag. - Extracts replication endpoint and kill-RS test logic into shared base classes with thin concrete subclasses.
- Updates multi-WAL and replication master tests to align with the JUnit 5 migration.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
TestReplicationSyncUpToolWithBulkLoadedData.java |
Migrates sync-up bulk-load test assertions/tags to JUnit 5. |
TestReplicationSyncUpToolBase.java |
Converts setup/teardown lifecycle hooks to JUnit 5. |
TestReplicationSyncUpTool.java |
Migrates sync-up tool tests and assertions to JUnit 5. |
TestReplicationKillSlaveRSWithSeparateOldWALs.java |
Rewires separate-old-WAL slave kill test to new base. |
TestReplicationKillSlaveRS.java |
Converts concrete slave kill test to JUnit 5 subclass. |
TestReplicationKillMasterRSWithSeparateOldWALs.java |
Rewires separate-old-WAL master kill test to new base. |
TestReplicationKillMasterRSCompressed.java |
Converts compressed master kill variant to JUnit 5 setup. |
TestReplicationKillMasterRS.java |
Converts concrete master kill test to JUnit 5 subclass. |
TestReplicationEndpoint.java |
Reduces endpoint test to tagged JUnit 5 subclass. |
ReplicationKillSlaveRSTestBase.java |
Adds shared slave-RS kill test method. |
ReplicationKillRSTestBase.java |
Renames/refactors common kill-RS logic for JUnit 5 bases. |
ReplicationKillMasterRSTestBase.java |
Adds shared master-RS kill test method. |
ReplicationEndpointTestBase.java |
Adds shared endpoint tests, helpers, and endpoint implementations. |
multiwal/TestReplicationSyncUpToolWithMultipleWAL.java |
Migrates multi-WAL sync-up variant tags to JUnit 5. |
multiwal/TestReplicationSyncUpToolWithMultipleAsyncWAL.java |
Migrates async multi-WAL sync-up variant tags to JUnit 5. |
multiwal/TestReplicationKillMasterRSCompressedWithMultipleWAL.java |
Recreates compressed multi-WAL setup on new base. |
multiwal/TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL.java |
Recreates compressed async multi-WAL setup on new base. |
multiwal/TestReplicationEndpointWithMultipleWAL.java |
Rewires endpoint multi-WAL variant to new base. |
multiwal/TestReplicationEndpointWithMultipleAsyncWAL.java |
Rewires endpoint async multi-WAL variant to new base. |
master/TestReplicationLogCleaner.java |
Migrates log cleaner test lifecycle/assertions/tags to JUnit 5. |
master/TestRecoverStandbyProcedure.java |
Migrates standby recovery procedure test lifecycle/assertions/tags. |
master/TestLogCleanerBarrier.java |
Migrates log cleaner barrier test to JUnit 5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+92
to
+96
| @AfterAll | ||
| public static void tearDownAfterClass() { | ||
| // check stop is called | ||
| assertTrue(ReplicationEndpointForTest.stoppedCount.get() > 0); | ||
| } |
| */ | ||
| package org.apache.hadoop.hbase.replication; | ||
|
|
||
| import static org.junit.Assert.assertNull; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.