Skip to content

HBASE-30317 Fix synchronization race in TestExecutorService #8531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sigma-Ma wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

HBASE-30317 Fix synchronization race in TestExecutorService #8531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ public void testExecutorService() throws Exception {
ExecutorStatus status = executor.getStatus();
assertTrue(status.queuedEvents.isEmpty());
assertEquals(5, status.running.size());
checkStatusDump(status);
Waiter.waitFor(mockedServer.getConfiguration(), 10000,
() -> checkStatusDump(executor.getStatus()));

// Now interrupt the running Executor
synchronized (lock) {
Expand Down Expand Up @@ -141,13 +142,13 @@ public void testExecutorService() throws Exception {
.submit(new TestEventHandler(mockedServer, EventType.M_SERVER_SHUTDOWN, lock, counter));
}

private void checkStatusDump(ExecutorStatus status) throws IOException {
private boolean checkStatusDump(ExecutorStatus status) throws IOException {
StringWriter sw = new StringWriter();
status.dumpTo(sw, "");
String dump = sw.toString();
LOG.info("Got status dump:\n" + dump);

assertTrue(dump.contains("Waiting on java.util.concurrent.atomic.AtomicBoolean"));
return dump.contains("Waiting on java.util.concurrent.atomic.AtomicBoolean");
}

public static class TestEventHandler extends EventHandler {
Expand Down