HBASE-30455 Run website lint in precommit refguide check - #8735
Merged
Merged
Conversation
- Precommit builds the site with -DskipTests, which selects ci-skip-tests - ci-skip-tests skipped lint, so Prettier/ESLint errors only failed the post-merge website job. Follow-up fixes so far: - HBASE-30289 - HBASE-30270 addendum - HBASE-30416 addendum
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds website linting to the ci-skip-tests workflow used by refguide checks.
Changes:
- Runs
npm run lintduring skipped-test CI. - Updates website workflow documentation.
| File | Description |
|---|---|
hbase-website/README.md |
Documents the updated CI workflow. |
hbase-website/package.json |
Adds lint execution to ci-skip-tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
NihalJain
approved these changes
Oct 3, 2026
Member
Author
|
@NihalJain Thanks for the approval. After your review I pushed one more commit, 7a0164f. No code or script changes. Please take a quick look. |
petersomogyi
approved these changes
Oct 4, 2026
NihalJain
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/HBASE-30455