Hive-29661: SLF4J multi-binding fix for beeline start#6540
Open
aturoczy wants to merge 2 commits into
Open
Conversation
difin
reviewed
Jun 22, 2026
| case "$x" in | ||
| *slf4j-reload4j*|*slf4j-log4j12*|*log4j-1.2*|*reload4j*) continue ;; | ||
| esac | ||
| beelineClasspath="${beelineClasspath}:${x}" |
Contributor
There was a problem hiding this comment.
beelineClasspath is seeded from HADOOP_CLASSPATH, but hadoop classpath --glob already includes those paths, so appending all glob entries duplicates them. It would be good to add a guard before the append to skip entries already in beelineClasspath:
if [[ ":${beelineClasspath}:" == *":${x}:"* ]]
then
continue
fi
immediately before this line:
beelineClasspath="${beelineClasspath}:${x}"
beelineClasspath is seeded from HADOOP_CLASSPATH, then extended with every entry from `hadoop classpath --glob`. Hadoop's own startup builds that glob from HADOOP_CLASSPATH plus its own jars/confs, so the two overlap and the same jar would land on the classpath twice. Add a literal-string substring guard before each append to skip entries already present; wrap both haystack and needle in `:` so the match is position-safe and partial-name jars (e.g. `b` inside `ab`) don't spuriously match.
|
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removing the SLF4J noise from the first startup lines would also make Beeline feel cleaner and more professional for both new and existing users. Like:
Why are the changes needed?
To remove unnecessary noise from user interface. For user this information does not need at all.
Does this PR introduce any user-facing change?
Yes, the users does not see SLF4J nonsense messages at beeline start.
How was this patch tested?
Manually tested.