Skip to content

mod_dav_fs: logging on COPY/MOVE failure path #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
notroj wants to merge 1 commit into from
+4 −0
Closed

mod_dav_fs: logging on COPY/MOVE failure path #760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/dav/fs/repos.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,8 @@ static dav_error * dav_fs_copymove_file(

if ((status = apr_file_open(&inf, src, APR_READ | APR_BINARY,
APR_OS_DEFAULT, p)) != APR_SUCCESS) {
ap_log_perror(APLOG_MARK, APLOG_ERR, status, p, APLOGNO()
"Could not open file %s for reading.", src);
/* ### use something besides 500? */
return dav_new_error(p, HTTP_INTERNAL_SERVER_ERROR, 0, status,
"Could not open file for reading");
Expand All @@ -402,6 +404,8 @@ static dav_error * dav_fs_copymove_file(
if (status != APR_SUCCESS) {
apr_file_close(inf);

ap_log_perror(APLOG_MARK, APLOG_ERR, status, p, APLOGNO()
"Could not open file %s for writing.", dst);
return dav_new_error(p, MAP_IO2HTTP(status), 0, status,
"Could not open file for writing");
}
Expand Down
Loading