Skip to content

Updated so that tests that don't use the suexec module don't load it #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulLodge wants to merge 4 commits into
base: trunk
Choose a base branch
from
+1 −2
Open

Updated so that tests that don't use the suexec module don't load it #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33f5dd4
Updated so that tests that don't use the suexec module don't load it
PaulLodge Nov 6, 2026
4fb4940
Fix for failing test_core_005_01_requestheader_note_rejected
PaulLodge Nov 9, 2026
0ad88f2
removing the suexec fixes test_core_005_01_requestheader_note_rejected
PaulLodge Nov 9, 2026
d0d9bdc
clean up unused import
PaulLodge Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/modules/core/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class CoreTestSetup(HttpdTestSetup):
def __init__(self, env: 'HttpdTestEnv'):
super().__init__(env=env)
self.add_source_dir(os.path.dirname(inspect.getfile(CoreTestSetup)))
self.add_modules(["cgid","include","userdir","suexec","headers"])

@covener covener Nov 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mod_headers is reasonable to leave in (notwithstanding that the CI failure might be showing that adding it back in didn't work?)

@PaulLodge PaulLodge Nov 9, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange as the error_log offset isn't being reset and has a large number, more than the actual error_log size, so for the scan_recent() is waits and times out after 10 seconds even though the expression is present. The code seems to sidestep the conftest for some reason, so it's worthy of further investigation to ascertain what's actually happening.

@PaulLodge PaulLodge Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the analysis it appears that the fix put in place, calls the class CoreTestEnv which in turn calls the apache restart and recreates the logs dir etc, unfortunately the log.py still has the "old" offset, which is larger than the current file, causing the scan_recent() to wait and then timeout causing the error.

Now, the question is, is the suexec actually needed? as from what I can tell it's not used any of these group of tests.

self.add_modules(["cgid","include","userdir","headers"])


class CoreTestEnv(HttpdTestEnv):
Expand Down
1 change: 0 additions & 1 deletion test/modules/core/test_005_userdir_headers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ def _class_scope(self, env):
conf = HttpdConf(env, extras={
'base': f"""
UserDir "{userdir_base}/*/public_html"

<Directory "{userdir_base}/*/public_html">
AllowOverride FileInfo
Options +ExecCGI
Expand Down
Loading