Repository navigation
Conversation
- describe cold-open and replay checks - preserve evidence when preflight refuses - clarify upgrade and recovery boundaries
- point both language pages to the validated source - retain the established upgrade warning text - keep the code and website guidance aligned
imbajin
left a comment
There was a problem hiding this comment.
Exact head/base and both file patches match fork Docs #47. Its original bilingual documentation was independently reviewed at 9/10; the follow-up two-link pin update was separately cross-checked at 9/10. No new documentation finding. Refusal, evidence preservation, unchanged ID format and the absence of automatic ownership repair are clear. This does not establish full original-version upgrade/replay/snapshot/per-replica rollback acceptance or replace implementation CI.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The EN and ZH text matches the paired implementation in hugegraph/hugegraph#301 at 27731930, but that implementation is not in apache/hugegraph, so the page would document a refusal that Apache builds do not perform and cite a fork PR as its source. Evidence: apache/hugegraph master 2ae73704c has no checkLegacyGraphIdData, resolveExistingDBPath or docs/store-graphid-upgrade.md (git grep); hugegraph/hugegraph#301 is open and unmerged; latest-head CI on 6596f60 is green (prepare, Build group 0, deploy, visual).
- scope the guard to builds containing the paired fix - link the Apache implementation and upgrade guide - add matching English and Chinese section headings
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The new section 9 in the EN and ZH hstore pages matches the implementation proposed in apache/hugegraph#3330 at its current head 27731930, and both earlier review points (unmerged-status caveat, own heading) are addressed at this head. Two wording and link points remain; the page still describes unmerged behaviour, so it should merge together with #3330 and be re-checked if that PR's head moves. Evidence: static comparison of 0f29645 against #3330 at 27731930 (GraphIdManager.checkLegacyGraphIdData prefix {0xff, 0xfe} over the graph tables, call sites in GraphIdManager.getGraphIdOrCreate, BusinessHandlerImpl cold createGraphDB and loadSnapshot, PartitionEngine.init, and RocksDBSession.resolveExistingDBPath / findLatestDBPath for retained versions and the missing-CURRENT rejection); apache/hugegraph master 0b7c0de3e and tag 1.7.0 have none of these; EN/ZH parity read line by line; PR checks on this head are green (prepare, Build group 0, deploy, visual). Site build not run locally.
- link the Apache pinned upgrade guide - clarify release and master guard availability - retain deployment-specific upgrade validation
中文说明 (Chinese Summary)
背景与目标
在 HugeGraph-Store (HStore) 启动或版本升级时,为防止历史遗留的 GraphID 格式异常破坏存储数据,系统引入了 历史 GraphID 预检拦截机制 (Upgrade Preflight)。本 PR 在中英文 HStore 配置文档中补充该预检检查的行为说明与运维处置指南。
主要改动
config-backend-hstore.md):边界与注意事项
English Description
Summary
Document the legacy GraphID upgrade preflight checks in HStore configuration pages, explaining fail-fast refusal behavior and operational steps for evidence preservation.
Key Changes
config-backend-hstore.md):Scope & Boundaries
Related Implementation PRs
Verification
dist/validate-links.sh)Implementation Overview