Repository navigation
Conversation
- document protocol 1 and matching client/server requirements - describe fixed owner lifecycle and permissions - clarify abnormal exit recovery and deployment limits
imbajin
left a comment
There was a problem hiding this comment.
Independent current-head documentation review:8/10. REST owner semantics match the proposed Server; the Loader build-availability qualification remains open.
- qualify owner protection as proposed and unreleased - pin paired Server and Client/Loader sources - explain restore capability checks and drained cleanup
- preserve old Server import behavior - scope ownership to ordinary imports - clarify manual owner-release recovery - keep Hubble cleanup in a separate change
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The REST and Loader text matches the paired implementations at their current heads, and the EN and CN pages agree; the inline comments cover four small gaps. The pages describe Server #3331 and Client/Loader #815 as unmerged, so please merge this after those two and then replace the wording about current master with the release that carries the feature. Evidence: read the full diff at 4ff825c (4 files, +155/-0); compared it with LoadingMode.java, GraphsAPI.java, HugeGraphAuthProxy.java and StandardHugeGraph.java in apache/hugegraph#3331 at 4a42a77, and with LoadContext.java, HugeGraphLoader.java and LoadingModeOwner.java in apache/hugegraph-toolchain#815 at 63cfd76; checked the mode setter roles on apache/hugegraph master 0b7c0de3e; checked that sections 6.3.5 and 3.4.6 follow the existing numbering and that both #loading-ownership anchors exist for the two cross-page links. No Hugo build was run locally; the Build group 0 check was still queued.
中文说明 (Chinese Summary)
背景与目标
在数据导入过程中,为防止多个 Loader 进程并发导入时相互覆盖图模式(Mode)状态,HugeGraph 引入了 LOADING 模式所有权 (Ownership) 机制。本 PR 同步完善 RESTful API 和 HugeGraph-Loader 的双语使用文档。
主要改动
graphs.md):6.3.5 LOADING 所有权小节:说明/graphspaces/{space}/graphs/{graph}/mode/owners接口的申请(acquire)与释放(release)协议。PUT /mode枚举修改接口会被拒绝。hugegraph-loader.md):3.4.6 并发导入与 LOADING 所有权小节。404(即对接未支持该接口的旧版 Server)时,才会自动降级为旧版枚举模式;其余错误(鉴权失败、网络异常等)均直接报错退出,避免脏状态。kill -9)或句柄丢失时的手动 REST 释放及 Server 重启恢复指引。边界与注意事项
English Description
Summary
Update bilingual documentation for Loader concurrent import protection and LOADING mode ownership:
/mode/ownersRESTful APIs and handle lifecycle.Key Changes
graphs.md):6.3.5 LOADING ownership: documentsGET/PUT /graphspaces/{space}/graphs/{graph}/mode/owners(acquire/releaseactions).PUT /modeis rejected while active owners hold the graph.hugegraph-loader.md):3.4.6 Concurrent imports and LOADING ownership.404(older Server); other errors (network, auth, acquire fail) fail immediately.kill -9).Scope & Boundaries
Related Implementation PRs
Verification
dist/validate-links.sh)