Repository navigation
feat(ci): run affected actions in better order - #779
Conversation
- cancel older runs of each PR workflow - verify retry source before and after the delay - test retry freshness and document CI behavior
- explain PR concurrency alongside workflow policy - match comments on active target branches - avoid conflicts when syncing master into PRs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #779 +/- ##
=============================================
- Coverage 62.49% 45.75% -16.75%
- Complexity 1903 4315 +2412
=============================================
Files 262 602 +340
Lines 9541 29044 +19503
Branches 886 3369 +2483
=============================================
+ Hits 5963 13288 +7325
- Misses 3190 14505 +11315
- Partials 388 1251 +863 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The concurrency groups look right and the checker's tests pass, but the new PR lookup never finds a fork PR, so automatic retries stop for every PR opened from a fork, including this one. Score 6/10. Evidence: ran test_check_rerun.py at the exact head (all pass), then ran decide() against real runs of this repo through gh api with the run forced to a failed state: fork PR #771 run 37298674115 returns skip ('no open PR in this repository with the failed head'), while same-repo PR #780 run 37263450044 returns rerun.
- select related modules and verify reusable test receipts - share immutable server fixtures with separate runtime services - isolate HDFS setup and bound downloads and readiness - defer security checks and preserve protection migration
- retain upstream client and installer compatibility fixes - reconcile shared artifacts with updated source provenance - keep automatic fixture checks in the unified CI entry
- restore existing version-specific archives - validate restored data with the pinned checksum - retain bounded download and readiness deadlines
- remove the extra trailing blank line - keep bounded service readiness behavior - pass the full pull request whitespace check
- merge upstream loader and tools preparation fixes - preserve Spark Java 17 test and release fixture setup - keep shared artifacts and affected-module orchestration
- retain affected suites and verified shared fixtures - test Toolchain on Java 17 with isolated Server JVMs - inherit existing Surefire and JaCoCo test-tool versions - gate both current and released Hubble fixtures
996ebbc to
c5a2524
Compare
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Score: 4/10. Summary: The plan/gate structure and receipt verification are careful, and the claim that business Java code, compiler targets and dependency sources are unchanged holds (only hubble-be test plugins move to the root Surefire/JaCoCo versions). One issue blocks: Analyze (java) fails on every docs-only push to master. Evidence: read the full diff against master (34 files); ran python3 -m unittest discover -s .github/scripts -p 'test_*.py' (40 tests OK), runtime_test.py (6 OK) and the three node --test suites (25 pass); parsed all workflow YAML and ran bash -n on every changed script; called select() and create_plan() with concrete paths and a push event. actionlint and shellcheck were not available. Required CI at c5a2524 is still queued and the four earlier runs on this branch were cancelled, so the new pipeline has not completed end to end yet. Not verified: Hadoop 3.3.6 daemons now inherit JDK 17 in the hdfs job (previously 11).
- include Go consumers of shared fixture scripts - verify packaged docs and optional proof provenance - restrict legacy security aliases and write permissions - document JDK coverage and pending runtime validation
- retain necessary fixture and plan artifacts for seven days - select image startup checks from packaging inputs - bind image reuse to complete source and job evidence - preserve module coverage and document retry limits
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The two commits since c5a2524 fix all the earlier points: Analyze (java) is PR-only now, scan write permission sits on the security job, Go is selected for the shared Client server scripts, the Hubble baseline only enters the fingerprint when Hubble is selected, the packaged Hubble README forces fresh validation, and fork PRs get a qualified owner:branch lookup in check-rerun.py. The new image jobs and image proofs look correct. One gap is left: no required job compiles Toolchain code with JDK 11 any more, but both Dockerfiles still build with JDK 11, so a Java source change that uses a post-11 API passes every required check and breaks the image build. Score 8/10. Evidence: read the full diff against master (37 files) and the incremental diff c5a2524..0613a57. python3 -m unittest discover -s .github/scripts -p 'test_*.py' gives 61 OK with 2 Server-only skips, runtime_test.py gives 6 OK, and the three node --test suites give 25 pass. Probed select() and select_images() with concrete paths. Compiled a List.of(1).stream().toList() call with -source 1.8 -target 1.8: javac 17 accepts it and javac 11 rejects it. Every required check at 0613a57 is green, including both image jobs; only codecov/project fails, because of the stale base.
- preserve upstream Boot 3 and Java 17 requirements - retain shared fixtures and both Server baselines - include upstream archive and launcher checks
- retain supported JVM validation after the Hubble merge - check final image entry points and public UI assets - remove untrusted result reuse and PR artifact retries - resolve consumed baselines and reject stale PR inputs
Use pinned Hadoop containers with reachable block endpoints Keep Java 11 and Java 17 consumer tests and bounded readiness Collect HDFS logs and clean up containers after testing Preserve historical CodeQL configuration identity
Select affected consumers and share Server preparation, while keeping each consumer's behavior tests independent.