Repository navigation
fix: keep source release helpers outside GitHub - #813
Conversation
Exclude GitHub and Hubble documentation screenshots from git archives. Keep frontend public and source assets available for builds. Reuse export-ignore without adding packaging scripts.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
============================================
+ Coverage 44.85% 47.03% +2.18%
- Complexity 3332 4517 +1185
============================================
Files 377 602 +225
Lines 22498 29444 +6946
Branches 3006 3454 +448
============================================
+ Hits 10092 13850 +3758
- Misses 11338 14312 +2974
- Partials 1068 1282 +214 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Move existing SDK and Server fixture helpers into source-owned paths. Exclude the complete GitHub directory from source archives. Update callers, CI, Docker contexts and documentation links without changing validation behavior.
imbajin
left a comment
There was a problem hiding this comment.
Current-delta source review: 8.5/10. The byte-identical verifier relocation and inspected Maven/Docker/CI consumers are consistent. P3: restoring relative screenshot links in README.md and hugegraph-hubble/README.md points retained documents back into export-ignored hugegraph-hubble/docs/images. The source archive loses these targets; the Hubble binary assembly also copies README* without that images directory. Please keep documentation references consistent with the delivered archive contents. This is documentation usability, not a confirmed build/runtime blocker; six references are not six independent defects. No artifacts or tests were executed.
|
Confirmed the screenshot packaging comment. The relative image links remain in the repository READMEs, while the referenced images are omitted from the source archive and Hubble binary package. This documentation usability limitation is tracked separately and has not been fixed by the verifier relocation. |
Organization counterpart: hugegraph#67.
Purpose of the PR
Source releases currently carry GitHub automation files because SDK verification and Server fixture helpers live under .github. Excluding .github without moving those dependencies would break source packaging or its integration scripts.
Main Changes
Verifying these changes
Paired validator compatibility: apache/hugegraph-doc#524. Merge it before using the new Toolchain source candidates; it retains support for already-uploaded candidates.
Does this PR potentially affect the following parts?
Documentation Status
Doc - Done: README.md, hugegraph-hubble/README.md and docs/java17-migration.md paths updated.Doc - TODODoc - No NeedConceptual overview
Conceptual overview: relocate the SDK verifier and four build helpers before excluding .github and Hubble documentation images; retain frontend runtime assets. Merge validator compatibility in apache/hugegraph-doc#524 before using new candidates. Not test evidence.