fix(ci): preserve PD and Store coverage aggregation - #3161
Draft
contrueCT wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
PD and Store CI run several Maven test profiles in separate invocations, but
each invocation previously replaced JaCoCo execution data and generated a
partial report. PD also ran
mvn clean packageafter two coverage-producingtest profiles, deleting their data before upload. As a result, Codecov could
receive only the last profile's coverage or an imprecisely selected report.
The existing JaCoCo 0.8.4 configuration also cannot instrument Java 17 class
files, which blocks the project's planned Java 17 migration.
Main Changes
data across Maven invocations.
verify that the final report contains the complete expected session set.
verifyand upload that exact fileto Codecov.
hg-store-rocksdbas a direct report-aggregate dependency only inthe
jacocoprofile so normal Store test dependency resolution is unchanged.that already-completed check during the final aggregate-only
verify.missing suites, missing modules, Maven lifecycle bindings, dependency scope,
and workflow paths.
Verifying these changes
hugegraph-server/hugegraph-dist/src/assembly/travis/test-check-jacoco-report.sh.github/workflows/pd-store-ci.ymlwith PyYAML and all changed POMswith
xmllint.mvn -q apache-rat:check -N -ntpmvn editorconfig:check -pl hugegraph-pd/hg-pd-test -am -ntpmvn editorconfig:check -pl hugegraph-store/hg-store-test -am -ntpmvn verify -pl hugegraph-pd/hg-pd-test -am -P jacoco -DskipTests -Deditorconfig.skip=true -ntpmvn verify -pl hugegraph-store/hg-store-test -am -P jacoco -DskipTests -Deditorconfig.skip=true -ntporg.javassist:javassist:3.24.0-GA.0.8.8 instruments the same class and writes execution data successfully.
The complete ten-profile PD/Store workflow and the external Codecov upload are
left to GitHub Actions because the local environment uses JDK 17 while this
workflow currently installs JDK 11.
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need