Skip to content

fix(server): bound final partition diagnostic - #3316

Merged
imbajin merged 1 commit into
apache:masterfrom
hugegraph:fix/partition-diagnostic-timeout
Oct 12, 2026
Merged

imbajin merged 1 commit into
apache:masterfrom
hugegraph:fix/partition-diagnostic-timeout

Conversation

@imbajin

@imbajin imbajin commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

After detecting assigned partitions, the Server entrypoint printed partition diagnostics with an unbounded HTTP request. A stalled response could keep the entrypoint waiting even after the JVM had exited.

Bound that final diagnostic with the existing WAIT_PARTITION_TIMEOUT_S setting. Partition polling and the final diagnostic each have their own timeout; signal forwarding and child-process cleanup are preserved. Observing a JVM exit may wait until the diagnostic completes or reaches its deadline.

Validation: a real stalled loopback HTTP response outlives the configured budget before the fix and times out afterward. The existing CI entrypoint suite verifies the JVM exit status, TERM/INT and process-group cleanup. Java 17 formatting, clean reactor compilation and three independent reviews passed. These checks cover shell/HTTP process behavior; real Docker/OOM and distributed acceptance remain open.

Related release issue: SV05, separate final-diagnostic defect. Repository Docker guidance is updated; paired website documentation is ASF doc #517, to be coordinated with this fix. The org comparison includes the already merged launcher baseline from current ASF master.

Change diagram

Separate timeout budgets for partition polling and the final HTTP diagnostic. This conceptual diagram does not replace the validation and scope notes above.
Separate timeout budgets for partition polling and the final HTTP diagnostic

- bound the final HTTP diagnostic with the existing budget
- preserve exit statuses and signal child-process cleanup
- document and test the two independent timeout stages
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.23%. Comparing base (cfc5c23) to head (c6009df).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3316      +/-   ##
============================================
- Coverage     52.24%   52.23%   -0.01%     
- Complexity     2274     2636     +362     
============================================
  Files           762      762              
  Lines         67399    67399              
  Branches       9138     9138              
============================================
- Hits          35211    35208       -3     
+ Misses        28649    28647       -2     
- Partials       3539     3544       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imbajin
imbajin merged commit 6aa362a into apache:master Oct 12, 2026
35 checks passed
@imbajin
imbajin deleted the fix/partition-diagnostic-timeout branch October 12, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants