Repository navigation
fix(server): bound final partition diagnostic - #3316
Merged
imbajin merged 1 commit intoOct 12, 2026
Merged
Conversation
- bound the final HTTP diagnostic with the existing budget - preserve exit statuses and signal child-process cleanup - document and test the two independent timeout stages
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3316 +/- ##
============================================
- Coverage 52.24% 52.23% -0.01%
- Complexity 2274 2636 +362
============================================
Files 762 762
Lines 67399 67399
Branches 9138 9138
============================================
- Hits 35211 35208 -3
+ Misses 28649 28647 -2
- Partials 3539 3544 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pengzna
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After detecting assigned partitions, the Server entrypoint printed partition diagnostics with an unbounded HTTP request. A stalled response could keep the entrypoint waiting even after the JVM had exited.
Bound that final diagnostic with the existing
WAIT_PARTITION_TIMEOUT_Ssetting. Partition polling and the final diagnostic each have their own timeout; signal forwarding and child-process cleanup are preserved. Observing a JVM exit may wait until the diagnostic completes or reaches its deadline.Validation: a real stalled loopback HTTP response outlives the configured budget before the fix and times out afterward. The existing CI entrypoint suite verifies the JVM exit status, TERM/INT and process-group cleanup. Java 17 formatting, clean reactor compilation and three independent reviews passed. These checks cover shell/HTTP process behavior; real Docker/OOM and distributed acceptance remain open.
Related release issue: SV05, separate final-diagnostic defect. Repository Docker guidance is updated; paired website documentation is ASF doc #517, to be coordinated with this fix. The org comparison includes the already merged launcher baseline from current ASF master.
Change diagram
Separate timeout budgets for partition polling and the final HTTP diagnostic. This conceptual diagram does not replace the validation and scope notes above.
