Repository navigation
fix: scope SVN additions to the current Server release - #3323
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3323 +/- ##
============================================
- Coverage 52.63% 52.61% -0.02%
+ Complexity 2435 2433 -2
============================================
Files 770 770
Lines 67694 67694
Branches 9172 9172
============================================
- Hits 35631 35620 -11
- Misses 28520 28528 +8
- Partials 3543 3546 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
imbajin
left a comment
There was a problem hiding this comment.
Independent cross-review at 69b0786: 9/10; no newly introduced blocker found in this focused change.
The version-qualified Server prefix excludes sibling AI/Computer/Toolchain artifacts while retaining the source/binary archives and their .asc/.sha512 sidecars. Checkout, copying, signing, checksum verification and commit behavior are unchanged; no --force was introduced. This remains a prefix glob, not an exact six-file manifest or an independent signature check.
Original upstream logs provide a useful before/after control: run 38280977141 failed when the broad add encountered already-versioned sibling files; run 38282771460 committed only the six Server artifacts as SVN r88470. Both used frozen source 6df8dd9; the successful run applied the same one-line fix to a sibling script whose full contents match this PR script. That supports this script change, but is not execution of every artifact built from the PR head or complete RC acceptance.
One inherited boundary: the remote wrapper explicitly runs bash -e, whereas the script itself does not establish global errexit. Do not describe this one-line change as adding general fail-fast behavior. Current PR CI must still be assessed separately.
Evidence: https://github.com/imbajin/nocode/actions/runs/38280977141/job/114917906042 and https://github.com/imbajin/nocode/actions/runs/38282771460/job/114923803162
When AI or Computer artifacts are already in the candidate directory, apache-hugegraph-* also matches those tracked files. svn add returns an error and the release workflow stops before committing Server packages.
Include the release version in the glob so only this Server release's source, binary, signatures and checksums are added. This is a one-line change; it introduces no dependencies or test framework.
Evidence: A publisher compatibility fix is being tested against the frozen 1.8.0 source remotely; no SVN artifacts are downloaded or validated locally.
Remote verification passed: https://github.com/imbajin/nocode/actions/runs/38282771460 uploaded exactly the six Server files alongside existing AI/Computer/Toolchain artifacts, committing SVN revision 88470. The signing key is imbajin (7F765B8EE09BAC82EE821311BA7E78F8A81A885E). An independent static review confirmed the narrowed glob, archive SHA preservation and failure-before-commit behavior for existing Server files.
Implementation overview
Version-qualified prefix selection for Server artifacts; sibling components are left untouched. This is not an exact six-file allowlist or release-acceptance evidence.