Skip to content

test: assert expired snapshot ids in expire_snapshots tests #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anxkhn wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −7
Open

test: assert expired snapshot ids in expire_snapshots tests #3615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions tests/table/test_expire_snapshots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,13 @@ def test_expire_unprotected_snapshot(table_v2: Table) -> None:
table_v2.maintenance.expire_snapshots().by_id(EXPIRE_SNAPSHOT).commit()

table_v2.catalog.commit_table.assert_called_once()
remaining_snapshots = table_v2.metadata.snapshots
assert EXPIRE_SNAPSHOT not in remaining_snapshots
assert len(table_v2.metadata.snapshots) == 1
# Inspect the RemoveSnapshotsUpdate actually sent to the catalog rather than the
# mocked commit response, so the assertion fails if the wrong ids are expired.
args, _ = table_v2.catalog.commit_table.call_args
updates = args[2] if len(args) > 2 else ()
remove_update = next((u for u in updates if getattr(u, "action", None) == "remove-snapshots"), None)
assert remove_update is not None
assert set(remove_update.snapshot_ids) == {EXPIRE_SNAPSHOT}


def test_expire_nonexistent_snapshot_raises(table_v2: Table) -> None:
Expand Down Expand Up @@ -222,10 +226,13 @@ def test_expire_snapshots_by_ids(table_v2: Table) -> None:
table_v2.maintenance.expire_snapshots().by_ids([EXPIRE_SNAPSHOT_1, EXPIRE_SNAPSHOT_2]).commit()

table_v2.catalog.commit_table.assert_called_once()
remaining_snapshots = table_v2.metadata.snapshots
assert EXPIRE_SNAPSHOT_1 not in remaining_snapshots
assert EXPIRE_SNAPSHOT_2 not in remaining_snapshots
assert len(table_v2.metadata.snapshots) == 1
# Inspect the RemoveSnapshotsUpdate actually sent to the catalog rather than the
# mocked commit response, so the assertion fails if the wrong ids are expired.
args, _ = table_v2.catalog.commit_table.call_args
updates = args[2] if len(args) > 2 else ()
remove_update = next((u for u in updates if getattr(u, "action", None) == "remove-snapshots"), None)
assert remove_update is not None
assert set(remove_update.snapshot_ids) == {EXPIRE_SNAPSHOT_1, EXPIRE_SNAPSHOT_2}


def test_thread_safety_fix() -> None:
Expand Down