Skip to content

fix: raise TypeError for unsupported partition source type #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anxkhn wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

fix: raise TypeError for unsupported partition source type #3617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyiceberg/partitioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ def _to_partition_representation(type: IcebergType, value: Any) -> Any:
can return date that still needs to be transformed into an int (days
since epoch).
"""
return TypeError(f"Unsupported partition field type: {type}")
raise TypeError(f"Unsupported partition field type: {type}")

@ebyhr ebyhr Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other same mistake as far as I checked.



@_to_partition_representation.register(TimestampType)
Expand Down
14 changes: 13 additions & 1 deletion tests/table/test_partitioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@
import pytest

from pyiceberg.exceptions import ValidationError
from pyiceberg.partitioning import UNPARTITIONED_PARTITION_SPEC, PartitionField, PartitionSpec
from pyiceberg.partitioning import (
UNPARTITIONED_PARTITION_SPEC,
PartitionField,
PartitionSpec,
_to_partition_representation,
)
from pyiceberg.schema import Schema
from pyiceberg.transforms import (
BucketTransform,
Expand Down Expand Up @@ -253,6 +258,13 @@ def test_transform_consistency_with_pyarrow_transform(source_type: PrimitiveType
assert t.transform(source_type)(value) == t.pyarrow_transform(source_type)(pa.array([value])).to_pylist()[0]


def test_to_partition_representation_unsupported_type() -> None:
unsupported_type = StructType(NestedField(1, "x", StringType()))

with pytest.raises(TypeError, match="Unsupported partition field type: struct"):
_to_partition_representation(unsupported_type, "value")


def test_deserialize_partition_field_v2() -> None:
json_partition_spec = """{"source-id": 1, "field-id": 1000, "transform": "truncate[19]", "name": "str_truncate"}"""

Expand Down