Infra: Require CI checks before auto-merge - #3832
Open
kevinjqliu wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CI/merge infrastructure so GitHub auto-merge cannot merge a PR until merge-critical workflows have actually produced the expected check contexts.
Changes:
- Removes
pull_request.pathsfilters from key workflows so they always run on PRs (preventing “required check pending because workflow was skipped”). - Adds an explicit
required_status_checks.contextsallowlist formainin.asf.yamlto require specific CI check contexts before merging.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/python-integration.yml | Removes PR path filters so integration suites always run on PRs. |
| .github/workflows/python-ci.yml | Removes PR path filters so unit/lint/Windows/smoke checks always run on PRs. |
| .github/workflows/check-md-link.yml | Removes PR path filters so markdown link checking runs on all PRs. |
| .asf.yaml | Explicitly enumerates required CI check contexts for branch protection / auto-merge gating. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
PR #3815 enabled auto-merge, but
mainhas no required status-check contexts. Adding them is necessary for two reasons:When a
pull_requestpath filter skips an entire workflow, GitHub does not report its check. Branch protection then waits indefinitely for that required check, preventing auto-merge. Removing the path filters ensures every required check reports a result on every PR.Are these changes tested?
Yes. Workflow linting, YAML validation, and commit hooks pass.
Are there any user-facing changes?
No.