Repository navigation
Add TimestampNano Literal - #3853
Closed
rambleraptor wants to merge 2 commits into
Closed
rambleraptor wants to merge 2 commits into
rambleraptor wants to merge 2 commits into
Conversation
rambleraptor
marked this pull request as ready for review
August 31, 2026 19:55
rambleraptor
requested review from
Fokko,
geruh and
kevinjqliu
and removed request for
geruh
September 4, 2026 19:33
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
7 tasks
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need to introduce a set of literals in order to make
timestamp_nsandtimestamptz_nsactually useful.I'm purposefully matching the Java implementation whenever possible. This is particularly important for potential overflows, since Java overflows more aggressively than Python does.
Are these changes tested?
Included unit tests.
Are there any user-facing changes?