Skip to content

feat(cpp): add functions related to consumers and offsets to high level client - #4180

Merged
hubcio merged 9 commits into
masterfrom
cpp-high-level-client-2
Sep 21, 2026
Merged

hubcio merged 9 commits into
masterfrom
cpp-high-level-client-2

Conversation

@slbotbm

@slbotbm slbotbm commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR address?

Closes #
Relates to #2100

Rationale

Contributes to completeness of cpp high level client

What changed?

Add the following functions:

  • CreateConsumerGroup
  • GetConsumerGroup
  • GetConsumerGroups
  • LeaveConsumerGroup
  • DeleteConsumerGroup
  • LeaveConsumerGroup
  • StoreConsumerOffset
  • GetConsumerOffset
  • DeleteConsumerOffset

and their associated data structs. Also add tests for consumer offset functions that were previously untested.

Also adds clang-tidy config.

Local Execution

  • Passed
  • Pre-commit hooks ran

AI Usage

If AI tools were used, please answer:

  1. Which tools? codex
  2. Scope of usage? code generation
  3. How did you verify the generated code works correctly? read through it, tested it, and guided creation
  4. Can you explain every line of the code if asked? yes

@slbotbm
slbotbm marked this pull request as draft September 14, 2026 16:55
@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-review PR is waiting on a reviewer labels Sep 14, 2026
@slbotbm
slbotbm marked this pull request as ready for review September 15, 2026 05:59
@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Sep 15, 2026
@numinnex

Copy link
Copy Markdown
Contributor

/dst

Comment thread foreign/cpp/include/iggy.hpp
Comment thread foreign/cpp/include/iggy.hpp Outdated
Comment thread foreign/cpp/include/iggy.hpp
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Sep 21, 2026
@slbotbm

slbotbm commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Sep 21, 2026
@hubcio
hubcio merged commit da4f318 into master Sep 21, 2026
32 checks passed
@hubcio
hubcio deleted the cpp-high-level-client-2 branch September 21, 2026 18:54
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants