Skip to content

feat(gateways): SASL/PLAIN authentication for the Kafka gateway - #4222

Open
numinnex wants to merge 5 commits into
masterfrom
kafka_proxy_auth
Open

numinnex wants to merge 5 commits into
masterfrom
kafka_proxy_auth

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.96%. Comparing base (2894368) to head (3739da8).

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #4222       +/-   ##
=============================================
- Coverage     87.62%   26.96%   -60.66%     
  Complexity     1575     1575               
=============================================
  Files          1284     1281        -3     
  Lines        225457   181924    -43533     
  Branches     188820   145288    -43532     
=============================================
- Hits         197549    49054   -148495     
- Misses        23177   131145   +107968     
+ Partials       4731     1725     -3006     
Components Coverage Δ
Rust Core 11.75% <ø> (-76.97%) ⬇️
Java SDK 68.68% <ø> (ø)
C# SDK 77.41% <ø> (+0.06%) ⬆️
Python SDK 90.97% <ø> (ø)
PHP SDK 85.67% <ø> (ø)
Node SDK 96.44% <ø> (+0.07%) ⬆️
Go SDK 70.14% <ø> (+0.08%) ⬆️
see 693 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio hubcio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SASL path has one blocking issue and a few smaller ones. The blocking one is the pre-auth ApiVersions allowance: it is only spent on a success answer, so a client that repeats a rejected version holds a max_connections permit forever. The rest are a startup panic from one env var, a concurrency default above the shard count, and some doc and dead-code cleanups.

Comment thread gateways/kafka/src/server.rs Outdated
Comment thread gateways/kafka/src/main.rs
Comment thread gateways/kafka/src/server.rs Outdated
Comment thread gateways/kafka/docs/AUTHENTICATION.md Outdated
Comment thread gateways/kafka/src/server.rs
Comment thread gateways/kafka/src/server.rs Outdated
Comment thread gateways/kafka/src/protocol/api.rs Outdated
Comment thread gateways/kafka/src/auth.rs Outdated
Comment thread gateways/kafka/tests/common/server.rs
Comment thread gateways/kafka/src/server.rs
@numinnex

Copy link
Copy Markdown
Contributor Author

/ready

hubcio
hubcio previously approved these changes Sep 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants