Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4222 +/- ##
=============================================
- Coverage 87.62% 26.96% -60.66%
Complexity 1575 1575
=============================================
Files 1284 1281 -3
Lines 225457 181924 -43533
Branches 188820 145288 -43532
=============================================
- Hits 197549 49054 -148495
- Misses 23177 131145 +107968
+ Partials 4731 1725 -3006
🚀 New features to boost your workflow:
|
6 tasks
hubcio
requested changes
Sep 21, 2026
hubcio
left a comment
Contributor
There was a problem hiding this comment.
The SASL path has one blocking issue and a few smaller ones. The blocking one is the pre-auth ApiVersions allowance: it is only spent on a success answer, so a client that repeats a rejected version holds a max_connections permit forever. The rest are a startup panic from one env var, a concurrency default above the shard count, and some doc and dead-code cleanups.
Contributor
Author
|
/ready |
hubcio
previously approved these changes
Sep 21, 2026
hubcio
approved these changes
Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.