Conversation
The triage bot applied labels from an artifact that a collector workflow uploaded on every comment and review. That artifact was the only source for who acted, their role, the PR number and the review state, and on a cross-fork PR the collector runs the PR's own copy of the workflow, so the base repository did not control that input. The bot now takes every fact from GitHub itself. Comments trigger the apply workflow directly, since issue_comment runs the default-branch workflow with the declared permissions, and land in seconds. For reviews the collector is a bare trigger relay; the apply run takes the reviewer and the reviewed head commit from the workflow_run payload, finds the open PR at that commit and reads the review from the API. S-stale removal on comment or review moves into the same run, retiring stale-prs-unmark-on-activity.yml. Commands, permissions, reactions and labels stay as documented in CONTRIBUTING. A push within the handoff window after a review now costs that review's automatic flip; the run logs it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4251 +/- ##
============================================
+ Coverage 87.54% 87.56% +0.02%
- Complexity 1575 1576 +1
============================================
Files 1284 1284
Lines 223942 223942
Branches 187305 187305
============================================
+ Hits 196050 196099 +49
+ Misses 23168 23099 -69
- Partials 4724 4744 +20
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The triage bot applied labels from an artifact that a collector
workflow uploaded on every comment and review. That artifact was the
only source for who acted, their role, the PR number and the review
state, and on a cross-fork PR the collector runs the PR's own copy of
the workflow, so the base repository did not control that input.
The bot now takes every fact from GitHub itself. Comments trigger the
apply workflow directly, since issue_comment runs the default-branch
workflow with the declared permissions, and land in seconds. For
reviews the collector is a bare trigger relay; the apply run takes the
reviewer and the reviewed head commit from the workflow_run payload,
finds the open PR at that commit and reads the review from the API.
S-stale removal on comment or review moves into the same run, retiring
stale-prs-unmark-on-activity.yml.
Commands, permissions, reactions and labels stay as documented in
CONTRIBUTING. A push within the handoff window after a review now
costs that review's automatic flip; the run logs it.