Skip to content

Fix double living table schema race in IT#17980

Open
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix-double-living-table-schema-race
Open

Fix double living table schema race in IT#17980
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix-double-living-table-schema-race

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

This PR fixes IoTDBPipeDoubleLivingIT#testBasicDoubleLiving by ensuring the receiver has synchronized the sender-side table data and schema before receiver-side table insertion starts. Without this wait, the receiver may try to auto-create a missing column from an insert statement that does not carry the column category, causing Unknown column category for s5. Cannot auto create column..

It also fixes the receiver-side tree insertion block to use receiverEnv.getConnection() instead of reusing the sender connection.

Verification

  • mvn spotless:apply -pl integration-test -P with-integration-tests
  • Attempted single IT verification with IoTDBPipeDoubleLivingIT#testBasicDoubleLiving; the run failed in setUp before reaching the test body because the local cluster did not start after 30 retries.

This PR has:

  • been self-reviewed.
  • modified existing integration tests.

Key changed/added classes (or packages if there are too many classes) in this PR
  • integration-test/src/test/java/org/apache/iotdb/pipe/it/dual/tablemodel/manual/enhanced/IoTDBPipeDoubleLivingIT.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants