Skip to content

Fix test helper JDBC cleanup and Pipe subtask stubbing race - #19160

Open
Caideyipi wants to merge 3 commits into
masterfrom
codex/fix-pipe-rejected-start-test-20261106
Open

Caideyipi wants to merge 3 commits into
masterfrom
codex/fix-pipe-rejected-start-test-20261106

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Close statements and helper-owned JDBC connections in executeNonQueries and tryExecuteNonQueriesWithRetry on success and failure. Keep caller-provided connections open and preserve SQL execution order, retry counts, and waits.
  • Add IoTDBTestUtilsIT regression coverage for successful execution, unchecked execution failures, and SQL exceptions.
  • Configure the rejected-submission Mockito stub before registering the processor subtask. Registration makes the spy visible to the background worker, so this avoids concurrent Mockito stubbing and worker invocation while preserving the rejection and rollback assertions.

Validation

  • JDBC cleanup change, before appending it to this branch: Spotless, git diff --check, and IT discovery/sharding checks passed. Clean test-compile for integration-test and its dependencies (37 modules) passed with exit code 0. No tests were run for this change; the three newly added regression tests remain unrun.
  • Pipe stubbing change, as previously validated: Spotless and a clean 28-module source build passed. PipeProcessorSubtaskExecutorTest (6 tests) and PipeSinkSubtaskExecutorTest (11 tests) passed.
  • These checks were not repeated after combining the changes. The combined PR head has not been rebuilt or retested. The full test suite and zh-locale build were not run.

@Caideyipi
Caideyipi marked this pull request as draft November 6, 2026 04:50
@Caideyipi Caideyipi changed the title Fix Pipe subtask executor test's Mockito stubbing race Fix test helper JDBC cleanup and Pipe subtask stubbing race Nov 6, 2026
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.53%. Comparing base (2075032) to head (dd24815).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #19160   +/-   ##
=========================================
  Coverage     48.53%   48.53%           
  Complexity      635      635           
=========================================
  Files          5573     5573           
  Lines        412215   412215           
  Branches      54338    54338           
=========================================
+ Hits         200059   200068    +9     
+ Misses       212156   212147    -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Caideyipi
Caideyipi marked this pull request as ready for review November 6, 2026 06:15
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant